Hello community, here is the log from the commit of package kgpg for openSUSE:Factory checked in at 2016-06-20 10:59:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kgpg (Old) and /work/SRC/openSUSE:Factory/.kgpg.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kgpg" Changes: -------- --- /work/SRC/openSUSE:Factory/kgpg/kgpg.changes 2016-05-31 12:17:40.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.kgpg.new/kgpg.changes 2016-06-20 11:00:00.000000000 +0200 @@ -1,0 +2,8 @@ +Fri Jun 10 17:58:17 UTC 2016 - tittiatc...@gmail.com + +- Update to KDE Applications 16.04.2 + * KDE Applications 16.04.2 + * https://www.kde.org/announcements/announce-applications-16.04.2.php + + +------------------------------------------------------------------- Old: ---- kgpg-16.04.1.tar.xz New: ---- kgpg-16.04.2.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kgpg.spec ++++++ --- /var/tmp/diff_new_pack.uH1bGa/_old 2016-06-20 11:00:01.000000000 +0200 +++ /var/tmp/diff_new_pack.uH1bGa/_new 2016-06-20 11:00:01.000000000 +0200 @@ -17,7 +17,7 @@ Name: kgpg -Version: 16.04.1 +Version: 16.04.2 Release: 0 Summary: Encryption Tool License: GPL-2.0+ ++++++ kgpg-16.04.1.tar.xz -> kgpg-16.04.2.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kgpg-16.04.1/keyinfodialog.cpp new/kgpg-16.04.2/keyinfodialog.cpp --- old/kgpg-16.04.1/keyinfodialog.cpp 2016-03-08 18:48:12.000000000 +0100 +++ new/kgpg-16.04.2/keyinfodialog.cpp 2016-06-06 18:58:55.000000000 +0200 @@ -29,7 +29,6 @@ #include <KGlobal> #include <KLocale> #include <KMessageBox> -#include <KPushButton> #include <KToolInvocation> #include <QApplication> #include <QCheckBox> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kgpg-16.04.1/model/kgpgsearchresultmodel.cpp new/kgpg-16.04.2/model/kgpgsearchresultmodel.cpp --- old/kgpg-16.04.1/model/kgpgsearchresultmodel.cpp 2016-03-08 18:48:12.000000000 +0100 +++ new/kgpg-16.04.2/model/kgpgsearchresultmodel.cpp 2016-06-06 18:58:55.000000000 +0200 @@ -16,6 +16,8 @@ #include <KDateTime> #include <KDebug> #include <KLocale> + +#include <QScopedPointer> #include <QString> #include <QStringList> #include <QTextCodec> @@ -352,7 +354,7 @@ } void -KGpgSearchResultModel::slotAddKey(QStringList lines) +KGpgSearchResultModel::slotAddKey(const QStringList &lines) { Q_ASSERT(!lines.isEmpty()); Q_ASSERT(lines.first().startsWith(QLatin1String("pub:"))); @@ -360,13 +362,15 @@ if (lines.count() == 1) return; - SearchResult *nkey = new SearchResult(lines.takeFirst()); - if (!nkey->m_validPub) { - delete nkey; + QStringList::const_iterator it = lines.constBegin(); + + QScopedPointer<SearchResult> nkey(new SearchResult(*it)); + if (!nkey->m_validPub) return; - } - foreach (const QString &line, lines) { + const QStringList::const_iterator itEnd = lines.constEnd(); + for (it++; it != itEnd; it++) { + const QString &line = *it; if (line.startsWith(QLatin1String("uid:"))) { QString kid = d->urlDecode(line.section(QLatin1Char( ':' ), 1, 1)); @@ -380,10 +384,7 @@ if (nkey->getUidCount() > 0) { beginInsertRows(QModelIndex(), d->m_items.count(), d->m_items.count()); - d->m_items.append(nkey); + d->m_items.append(nkey.take()); endInsertRows(); - } else { - // key server sent back a crappy key - delete nkey; } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kgpg-16.04.1/model/kgpgsearchresultmodel.h new/kgpg-16.04.2/model/kgpgsearchresultmodel.h --- old/kgpg-16.04.1/model/kgpgsearchresultmodel.h 2016-03-08 18:48:12.000000000 +0100 +++ new/kgpg-16.04.2/model/kgpgsearchresultmodel.h 2016-06-06 18:58:55.000000000 +0200 @@ -20,12 +20,10 @@ #define KGPGSEARCHRESULTMODEL_H #include <QAbstractItemModel> +#include <QStringList> #include <kgpgcompiler.h> -class QString; -class QStringList; - class KGpgSearchResultModelPrivate; /** @@ -56,7 +54,7 @@ const QString &idForIndex(const QModelIndex &index) const; public slots: - void slotAddKey(QStringList lines); + void slotAddKey(const QStringList &lines); private: KGpgSearchResultModelPrivate * const d;
