Maurice,
This doesn't take into account the fact that request.getQueryString() can
return null, and then parseQueryString throws an NPE.
At least I think :)
-mike
------ Forwarded Message
From: [EMAIL PROTECTED]
Date: Sat, 02 Nov 2002 05:44:42 -0800
To: [EMAIL PROTECTED]
Subject: [Opensymphony-cvsmail] webwork/src/main/webwork/view/taglib
URLTag.java,1.14,1.15
Update of /cvsroot/opensymphony/webwork/src/main/webwork/view/taglib
In directory usw-pr-cvs1:/tmp/cvs-serv19856/src/main/webwork/view/taglib
Modified Files:
URLTag.java
Log Message:
oops. I had inadvertantlly rolled out a recent change by Rickard.
Index: URLTag.java
===================================================================
RCS file:
/cvsroot/opensymphony/webwork/src/main/webwork/view/taglib/URLTag.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- URLTag.java 1 Nov 2002 04:37:00 -0000 1.14
+++ URLTag.java 2 Nov 2002 13:44:40 -0000 1.15
@@ -8,8 +8,7 @@
import org.apache.commons.logging.*;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.*;
import javax.servlet.jsp.JspException;
import javax.servlet.jsp.JspTagException;
import java.io.IOException;
@@ -78,7 +77,9 @@
if (params==null) {
params = new HashMap();
}
- params.putAll(((HttpServletRequest)
pageContext.getRequest()).getParameterMap());
+ // Parse the query string to make sure that the parameters come
from the query, and not some posted data
+ HttpServletRequest req = ((HttpServletRequest)
pageContext.getRequest());
+
params.putAll(HttpUtils.parseQueryString(req.getQueryString()));
} catch (Exception e) {
LogFactory.getLog(this.getClass()).warn("Unable to put request
parameters into parameter map.", e);
}
-------------------------------------------------------
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-cvsmail mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-cvsmail
------ End of Forwarded Message
-------------------------------------------------------
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
