Vedovato Paolo wrote:
Could this taglib performance improvement be examined a little deeper for
1.3? This would a very big gain for webwork especially when having a look at
the JSTL comparison mentioned by Maurice.
Cheers
-Paolo
-----Original Message-----
From: Maurice Parker [mailto:maurice.parker@;pmic.com]
Sent: Tuesday, November 05, 2002 8:25 PM
To: [EMAIL PROTECTED]
Subject: Re: [OS-webwork] Re: OGNL
Bill,
I've never profiled the EL and taglibs. Do you have anymore details about what in the findValue() method is eating cycles? I think you mentioned PropertyEditor in the past.
BTW, there is probably lots of room for improvement in our Taglib implementation. I once coded a JSTL version of monthlist.jsp and it ran in about a third of the time. I would expect us to be somewhat slower because of added functionality and the upward stack search, but not that slower.
-Maurice
Bill Lynch wrote:
Pat,implementation of
What would the performance difference be between the current
ValueStack.findValue() vs the OGNL-implemented one? In all myprofiling,
ValueStack.findValue() always pops to the top as the methodthat takes the
longest.think of better
Regards,
--Bill
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:opensymphony-webwork-admin@;lists.sourceforge.net]On Behalf Of
Patrick Lightbody
Sent: Tuesday, November 05, 2002 1:41 PM
To: [EMAIL PROTECTED]
Subject: Re: [OS-webwork] Re: OGNL
Yup yup...
One note (just to keep everyone aware and maybe they can
(it does it'sideas):
ValueStack.findValue() does not use BeanUtil to find values
change findValue()own reflection). One thing that would be nice would be to
Then, in orderto use Ognl in the future for getting properties from beans.
(I'll keep usingto make it possible to type-convert back to original form
Class to findthe MM/dd/yyyy example), findValue must be able to take an a
but it could bethe value as:
findValue(String expr) {
return findValue(expr, Object.class);
}
findValue(String expr, Class clazz) {
....
// I need a property from a bean
Ognl.getValue(bean, context, expr, clazz);
....
}
Overall, I think the ValueStack is a very useful feature,
context will hold the"more informed" so to speak. For example, in Ognl, the
operation. If intype converter that is to be used for the get/setValue
global/bean/property-levelXWork (again, all hypothetical) you can configure
made, thetype-converters, then when the above Ognl.getValue() call is
somewhat tough (ifcontext must have the right type-converter set. This is
UNinformed. Itnot impossible) given the current ValueStack design.
The ValueStack is a dumb stack, so to speak. It's very, very
doing it in. Anddoes the job, but it doesn't know the context in which it's
Ognl.getValue). This is verythe value stack GETS values from beans (think
the code is very,different from the dispatchers (GenericDispatcher), where
and thereforevery INformed. It knows exactly the context it's running in
mix-matchcan SET bean values correctly (think Ognl.setValue). So this
the meantime Ibetween the dispatch and the ValueStack is bad and should be fixed in
version 2.0.
-Pat
----- Original Message -----
From: "Maurice Parker" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, November 05, 2002 10:30 AM
Subject: Re: [OS-webwork] Re: OGNL
Chris Miller wrote:extremely
Maurice's point about stability before functionality is of course
valid too, but if Pat is keen to code this on a branch in
coming fromcan't see any reason to discourage him.Let me let everyone know a little bit more about where I'm
Neither of uson this. Of the new code in CVS that has caused so many problems,
Patrick and myself are the two of the main contributers.
better thanhas done good job on quality with that code and Rickard rightfully
chewed our asses for it.
I feel that if you add code to the CVS repository you have the
responsibility of leaving it at least as good and hopefully
testsuite, tryingbefore. To make things right I am working on the new
OGNL stuff canto find bugs, and working my way through the bugs in Jira.
I think Patrick feels much the same way that I do, so the
integrating it oncewait a little longer.implemented
-Maurice
"Hani Suleiman" <[EMAIL PROTECTED]> wrote in message
news:1036517903.3dc8020f7b62a@;mail.formicary.net...
Well, the ognl stuff seems very promising, how about having it
on a
branch (say, OGNL_1 or something), with a view to
perspective atothers
have had a look and feel it's worthwhile?
Again, I stress that the goal for adding it (from my
and absolutely NOleast)
is
performance. There should be NO configuration changes,
positive step, itugly/unusable/slow/unfashionable,external changes. The only different (hopefully) will be superiorperformance on
the branch version. If it ends up being
the
branch can merrily die off, if it's useful/pretty/a
--------------------------------------------------------------------------------------------------------------can
--------------------------------------------------------------------------------------------------------------land
on HEAD. Any objections?
-------------------------------------------------------
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
-------------------------------------------------------
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
This sf.net email is sponsored by: See the NEW Palm
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
This sf.net email is sponsored by: See the NEW Palm Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
This sf.net email is sponsored by: See the NEW Palm Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork