> -----Original Message----- > From: Erik Beeson [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 26, 2003 10:59 PM > To: [EMAIL PROTECTED] > Subject: RE: [OS-webwork] ww2: ServletContext and ServletActionContext > > > On Wed, 26 Feb 2003, Jason Carreira wrote: > > Not sure what you mean here. You didn't add it to the ActionContext > > class? No, wait... Looks like you added it to the extra > context that > > is passed in to create the ActionContext by the > ServletDispatcher. Ok. > > That seemed like the logical place for it.
Yep, I just wasn't sure what you meant. > > > How about making ServletActionContext extend ActionContext, > only have > > a private constructor? That way, you can still get at all > of the old > > stuff from ActionContext plus the new stuff by just using > > ServletActionContext and you don't have to use ActionContext from > > Webwork. > > I did that first, but got into ugly constructor issues. > Making it private fixed it though, good call. committed. Cool. > > > I've made this change on mine.... Of course, I can't see if > it still > > passes your unit tests because there aren't any... :-) > > My unit testing is limited to copying already existing unit > tests and making them work for my situation. As there seems > to be no ActionContextTest, I was at a loss for a > ServletActionContextTest. I'm happy to write unit tests for > all my code, I just need to figure out how. > > Can you recommend a nice junit cookbook? :) > Hmm.. Not really. I've just done the old "Learn by Doing" and looking at others. There was a good series of articles in Software Development magazine telling a fictional story of a new developer joining an organization and learning test-first development... Not sure if they're online. I'll write up some simple unit tests for ActionContext and ServletActionContext. Jason ------------------------------------------------------- This SF.net email is sponsored by: Scholarships for Techies! Can't afford IT training? All 2003 ictp students receive scholarships. Get hands-on training in Microsoft, Cisco, Sun, Linux/UNIX, and more. www.ictp.com/training/sourceforge.asp _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
