I used the existing WebWork 1 URLTag implementation when I ported over the new version. When I did, I made a quick check at the CVS commit log to get an idea where the tag started to the current version. The last (most recent) entry was made by Rickard with the following reference:
Handle case where # anchors are used
Since that was the last commit, I assumed that it was added to resolve a known issue. I had trouble coming up with a test case for it, but decided to leave it in. Maybe Rickard could shed some light on the issue. If we had a solid test case we could determine if using getParameterMap() would be better. Using getParameterMap() looks a lot cleaner to me, so if it works we should probably back port it to the 1.3 branch.
-Brock
From: "Jason Carreira" <[EMAIL PROTECTED]> Reply-To: [EMAIL PROTECTED] To: <[EMAIL PROTECTED]> Subject: [OS-webwork] URL tag submitted Date: Tue, 25 Mar 2003 15:29:28 -0800
Rick added a URLTag implementation as an attachment on Jira that was developed by Brock Bulger.. I'm wondering what this part is doing, and why it is necessary?
HttpServletRequest req = (HttpServletRequest) pageContext.getRequest(); String query = req.getQueryString();
if (query != null) { int idx = query.lastIndexOf('#');
if (idx != -1) { query = query.substring(0, idx - 1); }
params.putAll(HttpUtils.parseQueryString(query)); }
Why do we need to chop the query string at '#'? The reason I noticed this is that HttpUtils is deprecated. You can get a map of params from the HttpServletRequest using getParameterMap(), but I'm wondering if that's a problem considering the above?
Thanks,
Jason
-- Jason Carreira Technical Architect, Notiva Corp. phone: 585.240.2793 fax: 585.272.8118 email: [EMAIL PROTECTED] --- Notiva - optimizing trade relationships (tm)
------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
_________________________________________________________________
MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*. http://join.msn.com/?page=features/virus
------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
