It should be created as a Jira issue > -----Original Message----- > From: Fernando Martins [mailto:[EMAIL PROTECTED] > Sent: Thursday, May 29, 2003 11:54 AM > To: [EMAIL PROTECTED] > Subject: Re: [OS-webwork] shouldn't VelocityResult set > charset in content-type? > > > > > Is there any JIRA issue on this, or should it be created to > that people interested in this issue could be notified when > something will be added/fixed. Are you planning to do some > work on this issue or could I propose some code changes to > support the webwork.i18n.encoding / velocity encoding ? > > > On Thu, 29 May 2003, Matt Ho wrote: > > > I agree with Scott on this, I think the i18n stuff should be in the > > webwork.properties file. However, I also think the ww2 should also > > support an optional velocity properties. > > > > M > > > > Fernando Martins wrote: > > > On Thu, 29 May 2003, Scott Farquhar wrote: > > > > > > > > >>Fernando, > > >> > > >>IMHO the encoding in webwork should be specified globally > using the > > >>webwork.i18n.encoding property, rather than in > velocity.properties. > > >> > > >>Can you add a JIRA issue for this? > > >> > > >> http://jira.opensymphony.com/ > > >> > > >>Cheers, > > >>Scott > > > > > > > > > I didn't add this to JIRA, because I was not sure if this > is really > > > some BUG, or I'm just missing something. I was hopping to > get some > > > clarification here on the list. I understand that to reduce > > > complexity, there could be webwork.i18n.encoding > property, but that > > > will also reduce flexibility to configure velocity to each one's > > > specific needs. I think both options will be able to co-exist > > > peacefully, with possibility to specify your encoding globally to > > > webwork or just in velocity. > > > I would like to hear opinion of others (maybe > VelocityResult @author Matt > > > Ho) in this subject, but probably this is not a priority > issue for en_US > > > people :) > > > > > > Fernando > > > > > > > > > > > > > > > > > >>Fernando Martins wrote: > > >> > > >>>In line 74 of VelocityResult there is: > > >>> > > >>> response.setContentType("text/html"); > > >>> > > >>>this doesn't account for different charsets that should be in > > >>>content-type if encoding being used is other than ISO-8859-1. > > >>> > > >>>in org.apache.velocity.Template there is method > getEncoding() which > > >>>I think should be used here to set the charset of content-type > > >>>i.e.: > > >>> > > >>> response.setContentType("text/html; > charset="+t.getEncoding()); > > >>> > > >>>This way, it will set content-type with the encoding velocity is > > >>>configured with (in velocity.properties encoding can be > specified. > > >>>How to get velocity to read those properties is another > story. In > > >>>my case I tried velocity-1.4-dev from CVS and it reads the > > >>>properties file). > > >>> > > >>>You can argue that if I want diferent encoding in my > pages I should > > >>>use > > >>>html: > > >>> > > >>><meta http-equiv="Content-type" > > >>>content="text/html;charset=iso-8859-2"> > > >>> > > >>>That works in normal cases, but if I need to compress the pages > > >>>with Gzip > > >>>(Content-Encoding: gzip) browsers will just not pay > attention to meta and > > >>>will set the encoding to what is in Content-Type. That's > why I need it to > > >>>have the correct encoding in Content-Type. > > >>> > > >>>Am I missing something obvious here? > > >>> > > >>>Thanks > > >>>Fernando > > >>> > > >>> > > >>> > > >>>------------------------------------------------------- > > >>>This SF.net email is sponsored by: eBay > > >>>Get office equipment for less on eBay! > > >>>http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 > > >>>_______________________________________________ > > >>>Opensymphony-webwork mailing list > > >>>[EMAIL PROTECTED] > > >>>https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > > >>> > > >> > > >> > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: eBay > > > Get office equipment for less on eBay! > > > http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 > > > _______________________________________________ > > > Opensymphony-webwork mailing list > > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > > > > > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: eBay > > Get office equipment for less on eBay! > > http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 > > _______________________________________________ > > Opensymphony-webwork mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: eBay > Get office equipment for less on eBay! > http://adfarm.mediaplex.com/ad/ck/711-11697-> 6916-5 > > _______________________________________________ > > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >
------------------------------------------------------- This SF.net email is sponsored by: eBay Get office equipment for less on eBay! http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
