Here are my observations on the Action issue:

>From a framework standpoint it doesn't really matter if there is an explicit
execute() method to call on the underlying object. The default behavior is
to call this method if no method is specified. So I don't think we lose
anything by changing the return type on those methods to Object.

>From a terminology standpoint and for consistency, I think the Action
interface should retain the execute() method. Developers associate "action"
objects as implementing a specific interface and I think the framework
should leverage this association. And that to me implies that the
ActionSupport class should continue to implement the Action interface and
the associated execute() method.

Now bear with me.

Create a new class (or rename the BaseActionSupport) called CommandSupport
(for command driven actions mind you) that implements everything in the
current BaseActionSupport minus the Action interface. This class will be
subclassed by anyone wanting to declare their own execution methods while
providing all the validation/locale support existing in ActionSupport.

Then the only issue is the result types (success, error, etc) which could be
refactored into a separate interface that both ActionSupport and
CommandSupport implement. In the end you would probably have something like:

public interface ResultTypes {
    // or another name that floats your boat
    public static final String SUCCESS = "success";
    // etc
}

public interface Action {
    public String execute() throws Exception;
}

public class CommandSupport implements ResultTypes, ValidationAware,
LocaleAware, Serializable {
}

public class ActionSupport extends CommandSupport implements Action {
}

This should give most people the flexibility to do what they want. Thoughts?

- Brock

// Make the simple things easy and the hard things possible.


----- Original Message ----- 
From: "Matt Ho" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, July 02, 2003 5:11 PM
Subject: Re: [OS-webwork] WebWork2, here I come!


> I think what would be really useful for the discussion are some concrete
> examples of pojos that would make use of multiple entry points.
> Certainly the workflow we've been talking about is one example, but I'd
> like to understand what some others are.
>
> M
>
> Jason Carreira wrote:
> > Amen brother!
> >
> >
> >>-----Original Message-----
> >>From: Mike Cannon-Brookes [mailto:[EMAIL PROTECTED]
> >>Sent: Wednesday, July 02, 2003 5:17 PM
> >>To: [EMAIL PROTECTED]
> >>Subject: Re: [OS-webwork] WebWork2, here I come!
> >>
> >>
> >>IMHO this is just over complicating things.
> >>
> >>Regardless of the _removal_ of Action, I'm for removing the
> >>execute() method and just making it default.
> >>
> >>Alias = action class + method name (default to execute())
> >>
> >>Could it get simpler? Why pass URL parameters and all this
> >>crazy complicated stuff?
> >>
> >>M
> >>
> >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> > Data Reports, E-commerce, Portals, and Forums are available now.
> > Download today and enter to win an XBOX or Visual Studio .NET.
> > http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
> > _______________________________________________
> > Opensymphony-webwork mailing list
> > [EMAIL PROTECTED]
> > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
>
>
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
> _______________________________________________
> Opensymphony-webwork mailing list
> [EMAIL PROTECTED]
> https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
>



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork

Reply via email to