I can see why the exception would be happening... parsing "true" to a number can't be done. Are you getting a thrown exception, or is it just being logged? I changed how exceptions are handled (user exceptions are thrown) but a side effect might be that you end up with things like this (which is bad, we generally want type conversion stuff to fail quietly).
As for the performance improvement, one reason for that is because XWorkConverter is no longer reading properties files on every request (just one of those things that I meant to get to but never did until now). -Pat ----- Original Message ----- From: "BOGAERT Mathias" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, August 28, 2003 4:00 AM Subject: [OS-webwork] Multiple problems > Hi guys, > > I tried upgrading my project to the latest xwork/webwork2 sources, and I > have some problems: > > - all error messages (action errors) are now surrounded with [ and ] > - a select with <option></option> (using emptyOption="true") throws an OGNL > exception: > > 20078 INFO [tcpConnection-81-1] (xwork.interceptor.LoggingInterceptor:44) - > Finishing execution stack for action create > 21406 INFO [tcpConnection-81-1] (xwork.interceptor.LoggingInterceptor:48) - > Starting execution stack for action createstep1-save > java.lang.NumberFormatException: For input string: "" > at > java.lang.NumberFormatException.forInputString(NumberFormatException.java:48 > ) > at java.lang.Long.parseLong(Long.java:415) > at java.lang.Long.parseLong(Long.java:452) > at ognl.OgnlOps.longValue(OgnlOps.java:87) > at ognl.OgnlOps.convertValue(OgnlOps.java:195) > at > ognl.DefaultTypeConverter.convertValue(DefaultTypeConverter.java:50) > at > com.opensymphony.xwork.XWorkBasicConverter.convertValue(XWorkBasicConverter. > java:79) > at > com.opensymphony.xwork.util.XWorkConverter.convertValue(XWorkConverter.java: > 123) > at ognl.OgnlRuntime.getConvertedType(OgnlRuntime.java:428) > at ognl.OgnlRuntime.getConvertedTypes(OgnlRuntime.java:447) > at ognl.OgnlRuntime.getConvertedMethodAndArgs(OgnlRuntime.java:473) > at ognl.OgnlRuntime.getAppropriateMethod(OgnlRuntime.java:523) > at ognl.OgnlRuntime.callAppropriateMethod(OgnlRuntime.java:535) > at ognl.OgnlRuntime.setMethodValue(OgnlRuntime.java:684) > at > ognl.ObjectPropertyAccessor.setPossibleProperty(ObjectPropertyAccessor.java: > 76) > at > ognl.ObjectPropertyAccessor.setProperty(ObjectPropertyAccessor.java:132) > at ognl.OgnlRuntime.setProperty(OgnlRuntime.java:1235) > at ognl.ASTProperty.setValueBody(ASTProperty.java:117) > at ognl.SimpleNode.setValue(SimpleNode.java:153) > at ognl.Ognl.setValue(Ognl.java:478) > at > com.opensymphony.xwork.util.OgnlUtil.setProperties(OgnlUtil.java:61) > at > com.opensymphony.xwork.interceptor.ParametersInterceptor.before(ParametersIn > terceptor.java:37) > at > com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterce > ptor.java:36) > at > com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocatio > n.java:149) > at > com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterce > ptor.java:37) > at > com.opensymphony.xwork.DefaultActionInvocation.invoke(DefaultActionInvocatio > n.java:149) > at > com.opensymphony.xwork.interceptor.AroundInterceptor.intercept(AroundInterce > ptor.java:37) > > I'm trying to solve these issues, but any pointers/help would be > appreciated! > Overall the latest CVS version seem faster. > > Cheers, > Mathias > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
