I've noticed ActionTag is patched, but I think it's not done very well. Basically I don't know why stack was not passed? In such case you cannot use the data from including page, which is exactly what I would expect if it's used as 'component view'.
Even if it is used as bean, no view - it's also useful to have stack. There may be a whole lot of actions that use previous actions, and stack data. Another thing I've immediately suffered from this implementation was buffer problems. Note that when you dispatch from inside of JSP you have to use PageContext.include(). Whe sun introduced body tags, it also introduced another level of buffering. To be able to deal with those buffers, you just have to use PageContext. Otherwise you might happen to find out that you are actually writing to /dev/null. It should be checked if there are other places, where PageContext should be passed to ServletDispacherResult. I also have a "checkstyle" note - I think that there may be more places where the order of lines should be checked. If you declare to throw exception from everywhere, you may easily ommit a place where the exception really occurs. Like it happens in ServletDispatcher where logging doesn't work for some exceptions. Notably those that occur in included requests. Regards, -- Mike ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
