There is no need to make the ActionTag keep the ActionContext around -- that's really unhealthy. However -- what we could do is put the ActionContext in a request attribute and then use that in all our tags -- that would solve it perfectly. Here's a visual of the problem that I quickly put together in fireworks (be amazed by my awesome graphics ability):
http://www.lightbody.net/webwork_flow.png So I suppose we could make all our tags get the AC from the request rather than the ThreadLocal. Hehe, I recall this is one of the reasons I opted for not having ActionContext a ThreadLocal, but I was voted down ;) (no, I don't really want to debate this again, it's staying as a TL for the foreseeable future) -Pat ----- Original Message ----- From: "Jason Carreira" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, September 30, 2003 6:16 AM Subject: RE: [OS-webwork] WW2 Tags in SiteMesh decorators What are you trying to do in your decorators? If you access things in the request, where the Action will be bound with its id, you can push this action onto the ValueStack using the ww:push tag and use all of the other tags as normal. I don't think we're going to make the ActionTag leave its ActionContext out there. It needs to be returned to the original. > -----Original Message----- > From: Frederick N. Brier [mailto:[EMAIL PROTECTED] > Sent: Monday, September 29, 2003 10:20 PM > To: [EMAIL PROTECTED] > Subject: Re: [OS-webwork] WW2 Tags in SiteMesh decorators > > > This is exactly what I got working this weekend with my change to the > <ww:action> tag. I am using Webwork2 with SItemesh. My > Action class is > populated via the interceptors and an IoC component and populates the > header.jsp referenced in my Sitemesh decorator default.jsp with a > <ww:property> from the Action. > > The reason it didn't work originally was the "ActionTag wipes out own > ActionContext" issue, now in Jira. > > Fred. > > At 03:38 PM 9/29/2003, you wrote: > >SiteMesh parses the HTML from WW and extract the meta tags, > the title > >and > >the content of the page. It then decorates the page using a template. > > > >Jérôme. > > > >Jason Carreira wrote: > > > >>Well, I'm not really familiar with Sitemesh's internals, but the > >>filter > >>could be processing before and/or after the request reaches > the Servlet... > >> > >> > >> > >>>-----Original Message----- > >>>From: Jerome BERNARD [mailto:[EMAIL PROTECTED] Sent: > >>>Monday, September 29, 2003 2:56 PM > >>>To: [EMAIL PROTECTED] > >>>Subject: Re: [OS-webwork] WW2 Tags in SiteMesh decorators > >>> > >>> > >>>I think this is the other way around: SiteMesh wraps the > output from > >>>WW > >>>into a decorated HTML page. > >>> > >>>Regards, > >>>Jérôme. > >>> > >>>Jason Carreira wrote: > >>> > >>> > >>> > >>>>The problem is that Sitemesh is a filter, so it operates > before any > >>>>WebWork code, so nothing is set up. > >>>> > >>>>I'm not sure of a solution... > >>>> > >>>>Jason > >>>> > >>>> > >>>> > >>>> > >>>>>-----Original Message----- > >>>>>From: Vincent Faidherbe [mailto:[EMAIL PROTECTED] > >>>>>Sent: Monday, September 29, 2003 4:45 AM > >>>>>To: [EMAIL PROTECTED] > >>>>>Subject: [OS-webwork] WW2 Tags in SiteMesh decorators > >>>>> > >>>>> > >>>>>It seems that it isn't possible to use WW2 tags in SiteMesh > >>>>>decorators because tags suchs ww:property or ww:iterator fail to > >>>>>rerieve the ValueStack from the ActionContext. I had a the same > >>>>>issue in a home-made tag but I fixed the > >>>problem by > >>> > >>>>>replacing the call ActionContext.getContext().getValueStack() by > >>>>>(OgnlValueStack)request.getAttribute("webwork.valueStack" > ). I think it > >>>>>should be an issue related to the fact that the ActionContext is > >>>>>thread-local variable. > >>>>>Any idea? > >>>>> > > > > > > > >------------------------------------------------------- > >This sf.net email is sponsored by:ThinkGeek > >Welcome to geek heaven. > >http://thinkgeek.com/sf > _______________________________________________ > >Opensymphony-webwork mailing list > >[EMAIL PROTECTED] > >https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork > ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
