Not creating a new HashMap all the time sounds like a good idea. I'd prefer to have it created lazily though so that it is not created when it is not needed (when you do not have any parameters for example).Hmm, no I didn't think about that. Seems StringBuffer is a bit of a crappy choice all around with issues like this and the fact that it synchronized totally needlessly. Anyhow, I am quite happy with the performance increase this change brought, and a few more milliseconds seems pointless to optimize away.
Concerning the StringBuffer re-use: Did you measure the performance gain that you got from that? Since the buffer will be set to shared when the toString() method is called it means that the StringBuffer.delete method will need to copy the buffer, so there will be some overhead there anyway.
Btw, I mistakenly wrote "twice" in my email before, this was somewhat of an understatement. The URLBean went from 1000ms to 200ms, so it's somewhat faster than just double :P
Anders Hovmöller
------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
