Hello, Thank you for providing this patch. It looks like your patch was indeed what was originally intended there, versions of the code in the now diverged upstream were changed in a similar manner.
I've committed your fix in SVN r22783. It will be included in the next tarball release of openvas-smb. Regards, Michael * Miguel Angel Cabrera Moya [11. Jul 2015]: > Hi, > > I just found that there is redundant assignment in that function. Here is > the patch > > Best regards > > Index: auth_sam_reply.c > =================================================================== > --- auth_sam_reply.c (revision 22782) > +++ auth_sam_reply.c (working copy) > @@ -52,7 +52,7 @@ > sam->home_drive.string = server_info->home_drive; > > sam->logon_count = server_info->logon_count; > - sam->bad_password_count = sam->bad_password_count; > + sam->bad_password_count = server_info->bad_password_count; > sam->rid = > server_info->account_sid->sub_auths[server_info->account_sid->num_auths-1]; > sam->primary_gid = > server_info->primary_group_sid->sub_auths[server_info->primary_group_sid->num_auths-1]; > _______________________________________________ > Openvas-devel mailing list > Openvas-devel@wald.intevation.org > https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-devel -- Michael Wiegand | Greenbone Networks GmbH | http://www.greenbone.net/ Neuer Graben 17, 49074 Osnabrück, Germany | AG Osnabrück, HR B 202460 Executive Directors: Lukas Grunwald, Dr. Jan-Oliver Wagner
pgpY7kKfJ0R6D.pgp
Description: PGP signature
_______________________________________________ Openvas-devel mailing list Openvas-devel@wald.intevation.org https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-devel
