Hello Sebastien,
Yes, NVT can be improved.
Thanks,
Antu Sanadi
On Sunday 04 October 2015 07:27 PM, Sebastien Aucouturier wrote:
please do not review or commit , my fix is bad.
I will come after with solution after validating it.
On Sat, Oct 3, 2015 at 6:56 PM, Sebastien Aucouturier
<[email protected] <mailto:[email protected]>> wrote:
This patch fix the following:
kb entry :
Win/MediaPlayer64/Ver
Win/MediaPlayer/Ver
are only set if wmpVer is not 0 !
previously if no media_player were installed
Win/MediaPlayer/Ver or Win/MediaPlayer64/Ver were set to 0.
i prefer have no kb entry if the soft is not installed.
diff -ur feed-150930/secpod_ms_win_media_player_detect_900173.nasl
/var/lib/openvas/plugins/secpod_ms_win_media_player_detect_900173.nasl
---
feed-150930/secpod_ms_win_media_player_detect_900173.nasl2015-04-09
07:18:01.000000000
+0000
+++
/var/lib/openvas/plugins/secpod_ms_win_media_player_detect_900173.nasl2015-09-29
07:57:20.000000000 +0000
@@ -130,26 +130,28 @@
if(!insloc)
insloc = "Could not find the install location from registry";
- # Set the KB item for Windows Media Player.
- set_kb_item(name:"Win/MediaPlayer/Ver", value:wmpVer);
-
- ## build cpe and store it as host_detail
- cpe = build_cpe(value:wmpVer, exp:"^([0-9.]+)",
base:"cpe:/a:microsoft:windows_media_player:");
- if(isnull(cpe))
- cpe = "cpe:/a:microsoft:windows_media_player";
-
- build_report(app: "Microsoft Windows Media Player", ver:wmpVer
, cpe: cpe, insloc: insloc);
-
- ## 64 bit apps on 64 bit platform
- if("x64" >< os_arch && "x86" >!< insloc)
- {
- set_kb_item(name:"Win/MediaPlayer64/Ver", value:wmpVer);
+ if(!isnull(wmpVer)){
+ # Set the KB item for Windows Media Player.
+ set_kb_item(name:"Win/MediaPlayer/Ver", value:wmpVer);
## build cpe and store it as host_detail
- cpe = build_cpe(value:wmpVer, exp:"^([0-9.]+)",
base:"cpe:/a:microsoft:windows_media_player:x64:");
+ cpe = build_cpe(value:wmpVer, exp:"^([0-9.]+)",
base:"cpe:/a:microsoft:windows_media_player:");
if(isnull(cpe))
- cpe = "cpe:/a:microsoft:windows_media_player:x64";
+ cpe = "cpe:/a:microsoft:windows_media_player";
build_report(app: "Microsoft Windows Media Player",
ver:wmpVer , cpe: cpe, insloc: insloc);
+
+ ## 64 bit apps on 64 bit platform
+ if("x64" >< os_arch && "x86" >!< insloc)
+ {
+ set_kb_item(name:"Win/MediaPlayer64/Ver", value:wmpVer);
+
+ ## build cpe and store it as host_detail
+ cpe = build_cpe(value:wmpVer, exp:"^([0-9.]+)",
base:"cpe:/a:microsoft:windows_media_player:x64:");
+ if(isnull(cpe))
+ cpe = "cpe:/a:microsoft:windows_media_player:x64";
+
+ build_report(app: "Microsoft Windows Media Player",
ver:wmpVer , cpe: cpe, insloc: insloc);
}
}
+}
do you agree ?
--
Sebastien Aucouturier , R&D Manager and Senior Technologist,
<http://secludit.com/>
Amazon WS Solutions Provider :
http://www.aws-partner-directory.com/PartnerDirectory/PartnerDetail?Name=SecludIT
HP Cloud Security Partner :
https://marketplace.hpcloud.com/secludit-elastic-detector
Agence Toulouse
GSM: 06.20.60.77.24
--
Sebastien Aucouturier , R&D Manager and Senior Technologist,
<http://secludit.com/>
Amazon WS Solutions Provider :
http://www.aws-partner-directory.com/PartnerDirectory/PartnerDetail?Name=SecludIT
HP Cloud Security Partner :
https://marketplace.hpcloud.com/secludit-elastic-detector
Agence Toulouse
GSM: 06.20.60.77.24
_______________________________________________
Openvas-plugins mailing list
[email protected]
https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-plugins
--
Saner Personal
A free vulnerability mitigation
software. Build strong defense.
http://www.secpod.com/saner-personal.html
_______________________________________________
Openvas-plugins mailing list
[email protected]
https://lists.wald.intevation.org/cgi-bin/mailman/listinfo/openvas-plugins
