Hi, On Mon, Jan 04, 2016 at 02:43:44PM +0200, Lev Stipakov wrote: > v2: better method naming > > On certain OSes (Windows, OS X) when network adapter is > disabled (ethernet cable pulled off, Wi-Fi hardware switch disabled), > operating system starts to use tun as an external interface. > Outgoing packets are routed to tun, UDP encapsulated, given to > routing table and sent to.. tun. > > As a consequence, system starts talking to itself on full power, > traffic counters skyrocket and user is not happy. > > To prevent that, drop packets which have gateway IP as > destination address. > > Tested on Win7/10, OS X. > > Trac #642 > > Signed-off-by: Lev Stipakov <lstipa...@gmail.com>
ACK.
Thanks for coding this, thanks to Valdikss for testing (David, can
you include the tested-by: in the commit?).
Code still looks good, as in "does what is advertised, and safely does so".
Per discussion with David, we're not totally happy with the performance
implications - but that's not your fault, our is_ipv4() and is_ipv6()
functions are really doing their job in a very non-optimized way (read:
all the work is done twice, once to find out whether it's v4, then
again to find out whether it's v6).
I volunteer to refactor the two places where is_ipv*() are called today
(thinking along the lines of "ip_version = get_ip_version(...)" and then
compare ip_version to "4" or "6" - plus, making this an inline function)
For now, we stick to "fixes the issue in a easy to read and non-intrusive
way", so it can go into 2.3.12.
thanks again :)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
