On Mon, Aug 29, 2016 at 10:38 AM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote:
> > On 29/08/16 11:10, Bojan Komazec wrote: > > Thanks a lot Samuli. > > > > I cloned "openvpn-build" repo yesterday and created my patch branch > > off the last commit on "release/2.3" but after reading your email I > > checked it out again and saw that my "release/2.3" was actually 1 > > commit behind the origin. I am still trying to understand how this > > difference happened but yeah, my patch is not necessary. > > > > Regarding the contribution process, I was reading > > https://community.openvpn.net/openvpn/wiki/CodeRepositories page > > which states: "All bug fixes should be developed against the > > master branch, and where it is decided to include such fixes in a > > minor release (2.1.x, 2.2.x, etc), it will be cherry-picked from > > the master branch and into the suitable release branches.". This is > > what made me thinking I should create a patch for "master" rather > > than "release/2.3". Did you suggest using release branch as a > > target because my patch was not a bug fix (but a simple build > > parameter update)? > > We have a few different contribution processes, depending on which > sub-project you contribute to. The process described above is for the > OpenVPN core; which is the part of OpenVPN which does all the crypto > stuff, tunnelling and networking stuff. As this project is security > sensitive and a bad patch can truly compromise the security, we have > quite a strict regime of reviewing patches before they get accepted > and included. In addition, with the OpenVPN core we want to have full > transparency in what gets accepted and in a distributed way which > keeps most of the important discussions preserved - even if GitHub > disappears in the future. > > The openvpn-build project is more about building the OpenVPN core and > related packages. Even though funky stuff can be done to the build > process, it is not considered as critical as other components by the > openvpn-build team. Hence as simpler approach for contributing. But > still, patches will be reviewed here too before they get merged; it's > just that the mailing list isn't mandatory for this project. > > I hope this clarified a few things. > > > - -- > kind regards, > > David Sommerseth > OpenVPN Technologies, Inc > That completely makes sense. Thanks David for clarification. Bojan
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
