On Wed, 29 Sep 2004, Remco Boom wrote:
> Hello all
>
> In the file openvpn.nsi.in version 1.2.2.9, This is the most recent file
> in CVS
> http://cvs.sourceforge.net/viewcvs.py/openvpn/openvpn/install-win32/openvpn.nsi.in?rev=1.2.2.9&view=markup
> I found a bug, When you reinstall the same version openvpn the old tap
> driver isn't removed and you endup with 2 tap drivers installed and
> openvpn doesn't work.
> To fix it, just change the following in the nsi file:
>
> At line 348 it says:
> nsExec::ExecToLog '"$INSTDIR\bin\tapinstall.exe" remove TAP'
> But is must be
> nsExec::ExecToLog '"$INSTDIR\bin\tapinstall.exe" remove ${TAP}'
>
> At line 351 it says:
> nsExec::ExecToLog '"$INSTDIR\bin\tapinstall.exe" remove TAPDEV'
> This must be
> nsExec::ExecToLog '"$INSTDIR\bin\tapinstall.exe" remove ${TAPDRV}'
>
> at line 353
> TAPDEV must also be replaced bij ${TAPDRV}
Are you sure?
The TAP and TAPDEV strings are the actual names of previous TAP-Win32
hardware IDs which we want to delete before installing the new TAP-Win32
driver.
For example in OpenVPN 1.x, the hwid is "TAP". If we change the NSIS code
to ${TAP}, now it will expand to "tap0801" which is the hwid for 2.0. So
we won't be deleting the old instance any longer, which is what this code
is supposed to be doing.
James
