-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/03/10 17:34, Davide Brini wrote:
>> > >>The only scripts that actually require bash are
>> > >> contrib/pull-resolv-conf/client.{up,down} ; they use the ${!var}
>> > >> variable indirection feature.
>>>
>>> > > Not only that, they also use arrays, which are not part of standard sh.
>>> > >
>>> > > For a POSIX-sh compliant solution thad does mostly the same thing (and
>>> > > handles multiple DOMAIN options as well, which client.{up,down} doesn't
>>> > > support), I suggest you look into the Gentoo-provided {up,down}.sh
>>> > > scripts (though they contain some Gentoo-specific parts, but those are
>>> > > easily removed).
>> >
>> > Agreed! If you have time to look at a patch for it, I'd appreciate
>> > that. It will go in as a separate patch, to keep the patch flow as
>> > simple as possible.
>> >
> Well, I was actually going to write a patch, but shortly after starting I
> found out that it would end up being essentially the same as Gentoo's scripts.
> Would it be worth separately maintaining something that has already been
> written somewhere else?
I would say that if there are things which are distro related, they
should either be found only in that distribution or we can consider (if
it is considered important by more people) to put distro specific stuff
into a separate folder in the OpenVPN source tree.
If it is possible to get some up/down scripts which are generic for the
vast majority of POSIX sh based distributions, that would be the
preferred approach. If not, then we are back to where we started :)
Did that answer your question?
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkuYF54ACgkQDC186MBRfrqHwACgpMmlJ9ZQU/CvppJ+3pq1s/ql
IqwAoJEk28vBEMeJn44K8sLoJ33h/rqs
=eOoy
-----END PGP SIGNATURE-----
