On Tue, Apr 13, 2010 at 4:49 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 10/04/10 09:05, Alon Bar-Lev wrote: >> Highly none standard autotools usage. >> Also requires awk which may not be available. >> Please REVERT. > > First of all, let's bring in the history. This feature was discussed in > the weekly meeting February 26, 2010. See the chat log at [1], around > the time stamp 20:45:15.
David, IRC is not a development tool, it is sync tool that require all to be available at the same time, which is never the case. I don't understand why you took this approach, but its down-side is that people discover such commits later on. > This patch-set provides one way of doing this, and it is a requested > feature. There are probably several ways how to solve this, this is one > way - and it might not be the best way. However, it is what we got > right now. But the knowledge of autotools is not at your disposal. > Alon, with all respect, it is great getting feedbacks to submitted > patches, even REVERT suggestions. Could you perhaps share some thoughts > about how to solve it, instead of just rejecting it? I did. I sent you an example of how we solve it in OpenSC and Suspend. http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613 autoconf log was NEVER intended to be used as programming interface, and is far than being stable. > For now, this patch-set is only in feat_misc branch. I've halted the > merge into allmerged for now. But unless we can get a better solution > (meaning: new patches with enhancements) to this feature within > reasonable time, this is how it will look like. The initial patch is > already ready and accepted. I am willing to drop using awk or whatever > else, as long as we do get this feature. How the feature is implemented > is less important. > > But this feature will be important for us when we begin to receive > feedbacks on the openvpn-testing version. I understand the need, but reject the miss-use of autoconf resources. In order to be compatible with as many environment as you can, you cannot use hacks and undocumented approaches. > > > kind regards, > > David Sommerseth > > > [1] <http://thread.gmane.org/gmane.network.openvpn.devel/3143> > > >> On Thu, Apr 8, 2010 at 10:44 PM, David Sommerseth >> <openvpn.l...@topphemmelig.net> wrote: >> On 30/03/10 14:12, David Sommerseth wrote: >>>>> This patch will create ./configure.h which will contain two new #define >>>>> strings. CONFIGURE_DEFINES will contain all USE, ENABLED, DISABLED and >>>>> DEPRECATED defines from ./config.h. CONFIGURE_CALL will contain the >>>>> complete ./configure line which was used when configuring the package >>>>> for building. >>>>> >>>>> Signed-off-by: David Sommerseth <d...@users.sourceforge.net> >>>>> --- >>>>> Makefile.am | 7 +++++++ >>>>> configure_h.awk | 39 +++++++++++++++++++++++++++++++++++++++ >>>>> configure_log.awk | 36 ++++++++++++++++++++++++++++++++++++ >>>>> options.c | 3 +++ >>>>> 4 files changed, 85 insertions(+), 0 deletions(-) >>>>> create mode 100644 configure_h.awk >>>>> create mode 100644 configure_log.awk >> >> Applied to the openvpn-testing.git feat_misc branch. To be merged into >> allmerged soon. >> Commit f27bf509315a48b0070294c3993a718df0c2626c >> >> >> kind regards, >> >> David Sommerseth >>> > - > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel >>> > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ > > iEYEARECAAYFAkvEdlIACgkQDC186MBRfrrimwCfYMO4m2CuY1KPNkLAtHFqL+pr > dqYAn3T0jEowiV9NQZ+8H3onrH+JFb1B > =qAhn > -----END PGP SIGNATURE----- >
