-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/01/11 10:53, Samuli Seppänen wrote:
> Hi all,
>
> Here's the first of a set of six patches that fix various issues with
> the Python-based build system. Also, some clarifying comments have been
> added to the existing code. After this patchset is merged it's possible
> to build openvpnserv.exe in addition to openvpn.exe and the TAP drivers.
> NSI installer integration is still mostly missing, but is coming up.
>
> This patch could be simplified by removing the #ifdef / #ifndef "depth"
> detection code. That code is a leftover from earlier implementation
> where all defines - not just #define ENABLE_SOMETHING - were parsed. The
> idea was to skip any defines inside an #ifdef block as there is no
> (easy) way to detect if they're enabled or not.
>
> Samuli
A few comments ...
+'''Generate a fake configure.h dynamically'''
+def build_configure_h(kv, configure_h_out, head_comment):
These two lines should be swapped. Python places the
function/method/class documentation as a part of the block it describes.
In addition, it is not a fake configure.h which is generated. This is
the proper creation of configure.h, as that file should only contain
configuration information, no matter build system.
So a proper way would be:
def build_configure_h(kv, configure_h_out, head_comment):
'''Generate a fake configure.h dynamically'''
Then you can do pydoc on the python file, or use the help() function in
python to get the documentation of a function/method/class/etc.
I suggest cleaning up these comments as a separate patch on top of this
patch.
Except of that, PATCH 1/6 gets an ACK from me.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk0kT6QACgkQDC186MBRfroVVwCfcn3fsl6q1hCacpFd3rIYGomd
BHkAoJDPL6IGoD2k/AFwmoOpGP+TSLdp
=kDXE
-----END PGP SIGNATURE-----
