-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 21/04/11 20:47, David Sommerseth wrote: > From: David Sommerseth <d...@users.sourceforge.net> > > A quick and dirty compile fix was introduced in commit 77d244050964525417, > and was accepted under the condition that it would be a temporary fix. > > As the usage of _snprintf() is realy not ideal on Windows, this patch > uses the same well tested openvpn_snprintf() function from buffer.c. > It was a longer discussion of several possibilities to re-use that code, > but in the end it seemed easier to just copy-paste this function to > openvpnserv.c for now. > > The reason for this conclusion was that the function is really simple, > well defined and will most likely not be changed much in the future. > It is also added a comment in openvpnserv.c where this function > has its origins. > > Signed-off-by: David Sommerseth <d...@users.sourceforge.net> > --- > service-win32/openvpnserv.c | 39 ++++++++++++++++++++++++++++----------- > 1 files changed, 28 insertions(+), 11 deletions(-)
ACKed by James Yonan on IRC 2011-04-11 18:51 UTC: <dazo> jamesyonan: do you have time to have a look at this patch? and ACK it if you agree ... <http://thread.gmane.org/gmane.network.openvpn.devel/4621> <jamesyonan> looking at it now... <jamesyonan> dazo: sure, looks fine Applied to master and cherry-picked to beta2.2. commit 47dd9a4d7b2930f6e1b5d6f0ce0c154efc87ac29 (beta2.2) commit df5a4380c3931520d5fae2b18f0fc2e67a883aae (master) Author: David Sommerseth <d...@users.sourceforge.net> List-Post: openvpn-devel@lists.sourceforge.net Date: Thu Apr 21 20:32:26 2011 +0200 Improve the mysprintf() issue in openvpnserv.c Signed-off-by: David Sommerseth <d...@users.sourceforge.net> Acked-by: James Yonan <ja...@openvpn.net> kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk2wgLMACgkQDC186MBRfrpHowCgnEQbjP2foyBbNtHcxULaVd4B MzEAn02/K92yp6ujE3d39gLpngghV7YG =jMRx -----END PGP SIGNATURE-----
