>>> In get_console_input_systemd() you do: >>> >>> + *input = 0; >>> >>> I think it would be better to do: CLEAR(*input) instead. Just setting >>> the first byte to 0, will not solve any leak possibilities. An >>> alternative is to use memset() directly, which the CLEAR() macro uses >>> (see basic.h:47), but we prefer to use CLEAR() over memset() directly. >> done (and I've also fixed some missing spaces in various location). >> >> See the new version attached. > Goodie! I presume you did some compile and sanity testing before > submitting the patch, so that it won't bite our compile farm :) I think we > have a F15 or F16 box (which uses systemd) in the farm, so we can enable > systemd features on that box. I got two F16 boxes which I can use for systemd testing. I'll integrate those with buildbot next week.
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
