-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/02/12 19:40, i...@novg.net wrote:
> When building a very minimal OpenVPN for OpenWRT with
> --disable-management among others, the compilaton fails due to
> ENABLE_CLIENT_CR being defined, although the management interface,
> which makes use of it, has been disabled.
>
> The attached simple patch checks for ENABLE_MANAGEMENT before defining
> ENABLE_CLIENT_CR.
>
I've already ACKed this patch in another response in this mail thread. But
here is the complete overview of all patches pushed out on the master branch
for the -testing and -stable source trees.
commit 2ee0dc2bd72ec318fcc227af54e5ca7e1384a6cc
Author: Igor Novgorodov <i...@novg.net>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Sun Feb 12 22:40:02 2012 +0400
The code blocks enabled by ENABLE_CLIENT_CR depends on management
If the management interface is not enabled, it makes no sense in
including the ENABLE_CLIENT_CR #ifdef blocks. This will also in
some configurations cause build issues if these blocks are enabled.
Signed-off-by: Igor Novgorodov <i...@novg.net>
Acked-by: David Sommerseth <dav...@redhat.com>
Signed-off-by: David Sommerseth <dav...@redhat.com>
commit ecede953d6366e9fbfecea62cc1f61fd2347dab7
Author: David Sommerseth <dav...@redhat.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Feb 13 16:03:46 2012 +0100
Remove --show-gateway if debug info is not enabled (--disable-debug)
The --show-gateway feature depends on functions only being enabled when
--disable-debug is _not_ used. As this I consider --show-gateway more
a handy function for debugging, removing this feature when
- --disable-debug
is used seems like the proper approach.
Signed-off-by: David Sommerseth <dav...@redhat.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
commit 22277ec675847f73203bf908144f9903d13e2869
Author: David Sommerseth <dav...@redhat.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Feb 13 15:52:00 2012 +0100
Fix compile issues when plug-ins are disabled.
Commit 1876ccd012e9e2ca6f8e1cd9e7e9bb4bf24ccecb modified
plugin_call() and introduced plugin_call_ssl(). But the similar
approach was missing for situations without plug-ins.
Solution: Rename plugin_call() in the #else !ENABLE_PLUGIN
section to plugin_call_ssl(). Then move the plugin_ssl() function
inside the #ifdef ENABLE_PLUGIN section outside the #ifdef, making
it available for builds with and without plug-ins enabled.
Signed-off-by: David Sommerseth <dav...@redhat.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk85Y4EACgkQDC186MBRfrpXCQCfbm+HLw3OwXQb3lcXXs1QWE3q
g5AAn0NvBrUZbEMryUQgVQaX+yNrUuk3
=TeUL
-----END PGP SIGNATURE-----
