On Mon, Mar 26, 2012 at 12:48 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote:
> On Mon, Mar 26, 2012 at 12:46 PM, David Sommerseth
> <openvpn.l...@topphemmelig.net> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 26/03/12 12:25, Alon Bar-Lev wrote:
>>> On Mon, Mar 26, 2012 at 11:22 AM, David Sommerseth
>>> <openvpn.l...@topphemmelig.net> wrote:
>>>>
>>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>>>>
>>>> On 24/03/12 08:58, Alon Bar-Lev wrote:
>>>>> --- .gitattributes | 1 + ChangeLog | 2 ++ 2 files
>>>>> changed, 3 insertions(+), 0 deletions(-) create mode 100644
>>>>> .gitattributes
>>>>>
>>>>> diff --git a/.gitattributes b/.gitattributes new file mode 100644
>>>>> index 0000000..9cf9e1f --- /dev/null +++ b/.gitattributes @@ -0,0
>>>>> +1 @@ +ChangeLog ident diff --git a/ChangeLog b/ChangeLog index
>>>>> d498344..d7cc77c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6
>>>>> +1,8 @@ OpenVPN Change Log Copyright (C) 2002-2011 OpenVPN
>>>>> Technologies, Inc. <sa...@openvpn.net>
>>>>>
>>>>> +$Id$ +
>>>>
>>>> What is the purpose of this change?
>>>
>>> Oh... I remembered that this was in tree long ago[1], thought that it
>>> was dropped out when moving to git not intentionally.
>>>
>>> If otherwise, ignore this patch.
>>>
>>> It is nice to see the revision of the changelog as most probably it
>>> is the last revision before release. So if one forget to tag or
>>> something the data is available.
>>
>> Yeah, I agree that such markers may make sense in some cases. But with
>> git, the closest you can get to make this useful is to use .gitattributes
>> which can be told to update this with the blob sha reference of the
>> ChangeLog file. But that's not much helpful in the end. So I rather
>> suggest we drop this one.
>>
>> There's a rather sane discussion here on this topic:
>> <http://stackoverflow.com/questions/384108/moving-from-cvs-to-git-id-equivalent>
>>
>> Currently, I update ChangeLog when tagging the tree when we're about to
>> do a new release. I use the output of git shortlog as a summary. This
>> information is also available in the message blob of signed tags as well.
>> This way, the ChangeLog is always updated with all committed changes,
>> and for a more verbose changelog, you have 'git log' (or the git web UI).
>
> OK.
> Drop it.
>
> Alon.
