On Thu, Apr 26, 2012 at 9:17 PM, Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Thu, Apr 26, 2012 at 09:06:19PM +0300, Alon Bar-Lev wrote: >> Right, the ipv6 was added indeed differently, without this conditionals. > > You missed the part that JJO's IPv6 code *was* added with conditionals, > and that caused problems. We *removed* the conditionals, and the resulting > code is easier to maintain now. > >> Because of this I did not perform this task as part of the major build >> cleanup, and left this for the next phase. >> Most of the lowlevel network code already has #ifdefs, I will try my >> best to find a way to do the conditional without much changes. > > I don't think that this is a useful way to spend your time. > > Nobody has ever asked for it, and I don't see anybody volunteering to > maintain the resulting extra complications. > > We want to *reduce* the number of #ifdef in the code.
Not necessary, I would like to make it compatible with other well behaved projects out there. Alon.
