Re: [Openvpn-devel] [PATCH 3/6] Remove ENABLE_INLINE_FILES conditionals, this code is always enabled and removing the #ifdef make the code a little bit clearer

[Gert Doering]

Hi,

On Mon, Jun 18, 2012 at 08:39:06PM +0200, Arne Schwabe wrote:
> @@ -95,9 +95,7 @@ typedef unsigned long ptr_type;
>   * A sort of pseudo-filename for data provided inline within
>   * the configuration file.
>   */
> -#if ENABLE_INLINE_FILES
>  #define INLINE_FILE_TAG "[[INLINE]]"
> -#endif

I'm generally OK with this, as the mass of #ifdef in the code really
make everything hard to read.  Formally, I'd like to see an ACK from
James, though, as this is "his code base" and maybe there is indeed
some use case where ENABLE_INLINE_FILES is not desired.

Samuli, can you put these two (3/6 and 4/6) on the next meeting agenda?

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

pgpP5G3lk5EfA.pgp
Description: PGP signature