Please apply. https://github.com/alonbl/openvpn/compare/master...unicode
On Thu, May 3, 2012 at 8:47 PM, Alon Bar-Lev <alon.bar...@gmail.com> wrote: > On Thu, May 3, 2012 at 1:53 PM, Samuli Seppänen <sam...@openvpn.net> wrote: >> >>> On Thu, May 3, 2012 at 10:26 AM, David Sommerseth >>> <openvpn.l...@topphemmelig.net> wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- >>>> Hash: SHA1 >>>> >>>> On 27/04/12 14:15, Alon Bar-Lev wrote: >>>>> 2012/4/27 Samuli Seppänen <sam...@openvpn.net>: >>>>>> Il 27.04.2012 12:18, Heiko Hund ha scritto: >>>>>>> On Friday 27 April 2012 09:54:15 Samuli Seppänen wrote: >>>>>>>> Anyways, I cross-compiled latest "master" with this patch >>>>>>>> applied and "bin" and "lib" directories on top of an existing >>>>>>>> openvpn-2.3-alpha1 install. The old "bin" directory was >>>>>>>> renamed to make sure none of it was used. I then renamed >>>>>>>> "openvpn.ovpn" to "ääliö.ovpn" and "ta.key" to "ääliö.key" >>>>>>>> using Windows Explorer. Then I updated the configuration file >>>>>>>> to point to these files using Notepad (and later Wordpad). >>>>>>> Notepad saves UTF-8 files with BOM, which is very uncommon. >>>>>>> Maybe that was the problem. I ran into that when I was testing >>>>>>> my patch. You might want to try using Notepad++ and save it as >>>>>>> UTF-8 without BOM. >>>>>>> >>>>>>> HTH Heiko >>>>>> Saved the configuration file to UTF-8 without BOM - after this I >>>>>> got no complaints from OpenVPN-GUI. Launching OpenVPN from the >>>>>> command prompt also worked... tls-auth was undefined in the >>>>>> config, and openvpn called like this: >>>>> if bom is a problem we should handle it properly in options.c, as >>>>> we cannot expect users to understand bom issues. >>>>> >>>>>>> openvpn --config ääliö.ovpn --tls-auth ääliö.key 1 >>>>>> Only minor issue was that the command prompt displayed funky >>>>>> characters instead of the proper ones: >>>>>> >>>>>> <http://users.utu.fi/sjsepp/cmd2.png> >>>>> Yes. this is OK. >>>> Just so that I understand this more properly. The reason this is >>>> okay, is that because cmd.exe is not UTF-8 capable when displaying the >>>> log data? >>> Yes. >>> The cmd uses the plain old DOS code page, and needs special fonts. >>> If you add --log parameter you will see this correctly. >>> >>> Alon. >>> >> Tested with --log parameter. The logfile[1] seems to use the UTF-8 >> encoding, and with proper viewers/editors the Scandinavian characters >> (a/o umlauts, ä/ö) look just fine. On Windows most editors/viewers[3] >> display funky two-byte characters, but that's probably expected. >> >> [1] An example log file is available here, search for "tls_auth_file": >> <http://users.utu.fi/sjsepp/openvpn-log.txt> >> [2] E.g. less and vi (in Git Bash), Wordpad, etc. >> > > So I guess now we are good. > Is anything else missing? > > Alon.
