On 06/11/12 11:03, David Sommerseth wrote:
> From: David Sommerseth <[email protected]>
> 
> In commit dc7be6d078ba106f9b0de12f3e879c3561c3c537 the string_alloc() call
> in pf_init_context() was modified to use the gc_arena object for memory
> allocation.  What was not taken into consideration was that 
> pf_destroy_context()
> was also freeing memory allocated by string_alloc(), and when 
> pf_init_context()
> is calling gc_free() a double-free situation showed up.
> 
> Lets remove the explict free, and let gc_free take care of all the memory 
> handling.
> 
> Reported-by: [email protected]
> Signed-off-by: David Sommerseth <[email protected]>
> ---
>  src/openvpn/pf.c |    1 -
>  1 file changed, 1 deletion(-)


Applied to master and beta/2.3 branches.

commit 1f300fe94f1bd521966bb05dea40edc1fae82b84 (master)
commit 03dfcd95b29eda81aee117bf9d28c001f2521e15 (beta/2.3)
Author: David Sommerseth <[email protected]>
List-Post: [email protected]
Date:   Tue Nov 6 10:59:01 2012 +0100

    Fix double-free issue in pf_destroy_context()

    Reported-by: [email protected]
    Signed-off-by: David Sommerseth <[email protected]>
    Acked-by: Gert Doering <[email protected]>
    Message-Id: [email protected]
    URL: http://article.gmane.org/gmane.network.openvpn.devel/7124


kind regards,

David Sommerseth

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to