[Openvpn-devel] [PATCH] Error message if max-routes used incorrectly

[Arne Schwabe]

the route/route-ipv6/redirect-gateway options allocate the route structe with 
max_routes number of routes. A max-routes after any of this commands has no 
effect. This can be problematic 
(http://code.google.com/p/ics-openvpn/issues/detail?id=101)

Signed-off-by: Arne Schwabe <a...@rfc2549.org>
---
 src/openvpn/options.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 9baa4ff..5f19c27 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -5141,6 +5141,11 @@ add_option (struct options *options,
          msg (msglevel, "--max-routes parameter is out of range");
          goto err;
        }
+      if (options->routes || options->routes_ipv6)
+       {
+               msg (msglevel, "--max-routes must to be specifed before any 
route/route-ipv6/redirect-gateway option");
+         goto err;
+       }
       options->max_routes = max_routes;
     }
   else if (streq (p[0], "route-gateway") && p[1])
-- 
1.7.9.5