Re: [Openvpn-devel] [PATCH 5/5] Emulate persist-tun on Android

[Gert Doering]

Hi,

On Sat, Apr 20, 2013 at 04:22:48PM +0200, Arne Schwabe wrote:
> On Android changing the configuration of tun is not possible. So instead of 
> reconfiguring the tun device, open a new tun device and close the old one if 
> needed

I'm not sure I like this patch.  Wouldn't it be easier to tackle this
in options.c with an

#ifdef TARGET_ANDROID
    msg(M_WARN, "notice: android cannot do --persist-tun, ignoring statement");
#else
    ... old code here
#endif

(if you have to reopen the tun anyway) - or does persist-tun have other 
side effects that I'm overlooking?
 
gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

pgpXlnzf5mndp.pgp
Description: PGP signature