Yes, your right, there is this one "debugging" line left
(it was just to be sure, the setting of auth_user_pass_file to "stdin"
is the first thing done).
-------- Original-Nachricht --------
Betreff: Re: [Openvpn-devel] [PATCH] Allow inlining of --auth-user-pass
Von: Davide Brini <dave...@gmx.com>
An: Max Muster <max.mus...@kaffeeschluerfer.com>
Kopie (CC): openvpn-devel@lists.sourceforge.net
Datum: Sa 12 Okt 2013 18:25:56 CEST
> So here we go, your points are all valid. The patch you attached has a
> spurious line, or maybe it's just my client that doesn't show it correctly,
> I see
>
> @@ -5835,7 +5872,12 @@
> VERIFY_PERMISSION (OPT_P_GENERAL);
> if (p[1])
> {
> - options->auth_user_pass_file = p[1];
> + options->auth_user_pass_file = p[1];
> + if (streq (p[1], INLINE_FILE_TAG) && p[2])
> + { msg (M_WARN, "options.c \n !!!SETTING !!! \n_ +5930,12 @@
> add_optio");
> + options->auth_user_pass_file = "stdin";
> + options->auth_user_pass_file_inline = p[2];
> + }
> }
>
> I don't think the !!!SETTING !!! line should be there, so I'm going
> to send a revised patch in a few minutes which essentially includes all your
> suggestions (and is against master, I'm not sure yours was against master).
> I'm also citing your contribution in the new text, which I think is
> deserved.
>
> Thanks also for showing that there is at least another person besides me
> interested in this functionality!
>
