Am 29.11.13 20:42, schrieb Gert Doering:
> Hi,
>
> On Mon, Nov 25, 2013 at 01:31:17PM +0100, Arne Schwabe wrote:
>> This patch contains a number of changes. I did not further spit this since 
>> some changes make only sense being changed together.
> ACK, but...
>
>  - some parts of the patch did not apply cleanly due to whitespace issues
>    (most likely I caused them in the previous merges, meh, but some of them
>    were not my doing...), so I had to apply a few things manually - I 
>    *think* I got it all right, but hey...
>
>    - while at it, I've cleaned up more whitespace (trailing blanks)
>
>  - as discussed on IRC, I've adapted the complex if() condition in socket.h
>    (link_socket_set_outgoing_addr()
>
>  - I've included the fix to make "openvpn --test-crypto" work again
>
>  - I've changed the patch to tun.c to use "local_public" (I assume this 
>    was intended and just a copy-paste overlook)
>
>  - I've changed the protocol list to add "tcp4-server", "tcp4-client", and
>    also changed "tcp-server" and "tcp-client" from AF_INET to AF_UNSPEC -
>    and I'm not 100% sure if that is "right" for tcp-server.
>
> So - amended patch below.  Arne, could you please verify that these changes
> are all good and formally ACK again?  Transparency, and such :-)
>
>
ACK and thanks for doing my work :)



Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to