On Sun, Nov 16, 2014 at 9:31 AM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > From: David Sommerseth <dav...@redhat.com> > > The system() call is prone to shell expansions and provides far more > environments variables to the executable run than what is usually > preferred. By moving over to exevce() shell expansions are far more > difficult to achieve and only the OpenVPN provided environment > variables are available. > > This is a response to the patch submitted to openvpn-devel ML: > http://article.gmane.org/gmane.network.openvpn.devel/7919 > > v2 - Pulling it up again, fixing a few whitespace and spelling issues > > Signed-off-by: David Sommerseth <dav...@redhat.com>
Just a general comment on the error handling: Instead of printing generic error messages when syscalls fail, wouldn't it be better to look up the actual error description using strerror(3)? This would include calls to malloc, fork, execve, and possibly others.
