On Thu, Dec 10, 2015 at 8:28 AM, Arne Schwabe <[email protected]> wrote:
> The scenario read the password from file and then ask the password per > console seems a bit strange. > You mean read the password from a file and then ask for the CR from the console. If someone combines a server that issues a challenge with the "--auth-user-pass FILE" option, neither dynamic nor static CR prompts ever happen, and auth always fails. This is because those CR sections are inside the block that is only entered if username_from_stdin || password_from_stdin is true, and they are false when a file supplies the values. I'll post a patch that separates out just this fix and make it on the change that moves the isatty() checks out of misc.c. It is also improved a bit from my prior patch set in that it moves the user_prompt and pass_prompt vars into code blocks where they are used (so they don't get set when they aren't needed). ..wayne..
