Hi, On Tue, Dec 15, 2015 at 5:16 PM, Wayne Davison <[email protected]> wrote:
> The code that reads the challenge response (both dynamic & static) will > not prompt the user if the username and password information was read > from a file. > Agreed this is not good and should be fixed. But the patch is broken > In the latest code this can be fixed by simply removing > the "if (username_from_stdin || password_from_stdin)" condition because > all the deeper code is already conditionalized adequately to only prompt > for the missing information. > This doesn't work: it messes up any response already read from the management interface. A simple way of doing this is to define a new variable, say, CR_from_stdin = true if not read from management. Then add "CR_from_stdin == true" to those two if (auth_challenge && ..) lines. The patch will still remain only a few lines and no changes in indentation/whitespace needed. The logic will stay the same as what its now too. Thanks, Selva
