Another ACK from me - the patch did not apply easily to current master as there was a change in context last December. So did a more in-depth review to ensure that the actual logic of get_user_pass_cr() is still matching the expectations of this change, and it should be fine.
(Somewhere in our patch queue, there's the "permit auth-user-pass as <INLINE>", but since that didn't apply and nobody felt like rebasing it, an eventual rebase will need to take *this* change into account as well) Your patch has been applied to the master branch. commit c9a35a20812aafdacc3682a0379f52126bd567ae Author: James Yonan List-Post: [email protected] Date: Thu Mar 3 01:19:05 2016 -0700 Added directive to specify HTTP proxy credentials in config. Signed-off-by: James Yonan <[email protected]> Acked-by: Arne Schwabe <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11283 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
