On 28/10/16 18:42, Heiko Hund wrote: > Move functionality to parse command strings into argv_parse_cmd(). > That is a preparation for the upcoming refactoring of argv_printf(). > > Signed-off-by: Heiko Hund <heiko.h...@sophos.com> > --- > src/openvpn/argv.c | 47 > +++++++++++++++++------------------- > src/openvpn/argv.h | 1 + > src/openvpn/errlevel.h | 2 +- > src/openvpn/init.c | 2 +- > src/openvpn/misc.c | 10 +++----- > src/openvpn/multi.c | 13 ++++------ > src/openvpn/options.c | 2 +- > src/openvpn/socket.c | 7 +++--- > src/openvpn/ssl_verify.c | 6 +++-- > tests/unit_tests/openvpn/test_argv.c | 18 +++++++++++--- > 10 files changed, 56 insertions(+), 52 deletions(-)
ACK. This is a bit more invasive, but all testing looks good. Code changes are reasonable. Tested with 'make check', separate tests using --auth-user-pass-verify on server side and a couple of valgrind checks. In addition, 'ip route' was executed. The argv_parse_cmd() is also generic and used all places where %sc was used before, I consider this smoke-testing good enough for now. As for the prior patches in this series, I will wait with applying this patch to the git tree until all the other patches in this series have been reviewed and ACKed. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
