Hi, On Wed, Nov 16, 2016 at 12:27:05PM -0500, Selva Nair wrote: > On Wed, Nov 16, 2016 at 11:07 AM, Steffan Karger <[email protected]> > wrote: > > > > I do not have any Windows test environments, so I'll admit that's a > > > bold (and risky) move of me. However, as you've identified, > > > S_IRWXG|S_IRWXO is not set so shouldn't cause any issues. > > > > Combined with a compile-test I just this and the fact that the worst > > thing that could happen is an incorrect warning (Windows builds never > > warned before), I feel confident enough to ACK this: > > > > ACK. > > But the question is will this compile for windows? I doubt it will unless > we add some dummy defines for S_IRWXG etc..
As Selva was afraid, it breaks windows compilation.
i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include
-I../../include -I../../src/compat -DWIN32_LEAN_AND_MEAN
-DNTDDI_VERSION=NTDDI_VISTA -D_WIN32_WINNT=_WIN32_WINNT_VISTA
-I/home/samuli/buildtest/openvpn-build/windows-nsis/tmp/image-i686/openvpn/include
-I/home/samuli/buildtest/openvpn-build/windows-nsis/tmp/image-i686/openvpn/include
-I/home/samuli/buildtest/openvpn-build/windows-nsis/tmp/image-i686/openvpn/include
-I/home/samuli/buildtest/openvpn-build/windows-nsis/tmp/image-i686/openvpn/include
-municode -UUNICODE -std=c99 -MT options.o -MD -MP -MF .deps/options.Tpo -c -o
options.o options.c
options.c: In function 'check_file_access':
options.c:2743:22: error: 'S_IRWXG' undeclared (first use in this function)
if (st.st_mode & (S_IRWXG|S_IRWXO))
^
options.c:2743:22: note: each undeclared identifier is reported only once for
each function it appears in
options.c:2743:30: error: 'S_IRWXO' undeclared (first use in this function)
if (st.st_mode & (S_IRWXG|S_IRWXO))
^
"I do not have a windows test environment, so I'll boldly and risky
commit something which is not a must-have for 2.4_beta1 but just a
code shuffling-around, and which breaks platforms" is not a very good
strategy.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]
fax: +49-89-35655025 [email protected]
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
