Le 12/17/16 à 11:44, Gert Doering a écrit : > Taking 2.4_rc2 and building on AIX with -Wall -Wno-pointer-sign is > actually much less bad than I thought :-) - but there are things in > there which are annoying, like these > > ../../../git/src/openvpn/route.c: In function 'add_route_ipv6': > ../../../git/src/openvpn/route.c:1834:10: warning: variable 'gateway_needed' > set but not used [-Wunused-but-set-variable] > bool gateway_needed = false; > ^ > > (fixing is easy, but implies adding an #ifdef TARGET_... orgy or > refactoring this whole code part - which should be done, but won't > happen "over night")
That's why I also suggested to have -Wno-unused, at least in a first time. My idea was to avoid regression and detect issues easily on exotic configuration (openssl without crypto), not to change the code style in OpenVPN. > More problematic are these: > > ../../../git/src/openvpn/socket.c: In function 'print_link_socket_actual_ex': > ../../../git/src/openvpn/socket.c:2802:21: warning: implicit declaration of > function 'if_indextoname' [-Wimplicit-function-declaration] > if_indextoname(act->pi.in6.ipi6_ifindex, ifname); > ^ > ../../../git/src/openvpn/socket.c: In function 'unix_socket_get_peer_uid_gid': > ../../../git/src/openvpn/socket.c:3950:5: warning: implicit declaration of > function 'getpeereid' [-Wimplicit-function-declaration] > if (getpeereid(sd, &u, &g) == -1) > > ../../../git/src/openvpn/tun.c: In function 'open_tun_generic': > ../../../git/src/openvpn/tun.c:1787:13: warning: implicit declaration of > function 'if_nametoindex' [-Wimplicit-function-declaration] > if (if_nametoindex( dev ) > 0) > > ... since we're really not supposed to redeclare system prototypes > (and if we do, it will break on other versions of AIX). :( But we could detect such case during configure and add declarations if needed. Julien
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
