On Wed, Jan 11, 2017 at 02:32:37PM +0800, Antonio Quartulli wrote:
> On Tue, Jan 10, 2017 at 10:35:10PM +0100, Steffan Karger wrote:
> > > @@ -6496,7 +6531,7 @@ add_option(struct options *options,
> > > else if (streq(p[0], "push") && p[1] && !p[2])
> > > {
> > > VERIFY_PERMISSION(OPT_P_PUSH);
> > > - push_options(options, &p[1], msglevel, &options->gc);
> > > + push_options(options, &p[1], is_inline, msglevel, &options->gc);
> >
> > Same as with 'plugin', I don't think we can inline a 'push' option?
>
>
> My understanding is that the code allows for push-options to be inline'd, but
> right now there is no push-option that can be used that way. Am I wrong?This said, I agree that we should just not support pushing inline options. As of now, none of the 'inlineable' options can be pushed. I'll send v3 soon! Thanks! Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
