On 28-06-17 23:05, Arne Schwabe wrote: > --- > src/openvpn/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/options.c b/src/openvpn/options.c > index 61af6e3a..d8049e76 100644 > --- a/src/openvpn/options.c > +++ b/src/openvpn/options.c > @@ -1697,7 +1697,7 @@ show_settings(const struct options *o) > > #ifdef ENABLE_CRYPTO > SHOW_STR(shared_secret_file); > - SHOW_INT(key_direction); > + SHOW_PARM(key_direction, keydirection2ascii(o->key_direction, false), > "%s"); > SHOW_STR(ciphername); > SHOW_BOOL(ncp_enabled); > SHOW_STR(ncp_ciphers); >
Makes sense, but keydirection2acrii() can return NULL, which technically is undefined behaviour as input for a %s format string specifier... I know it's slightly lame, but still think either keydirection2ascii should always return a valid string, or this needs to wrapped in a np() call. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
