Hi, On Mon, Jul 10, 2017 at 12:34:39PM +0800, Antonio Quartulli wrote: > /* NTLMv2 hash */ > - my_strupr((unsigned char *)strcpy(userdomain, username)); > + my_strupr(strcpy(userdomain, username));
While at it, could you change that eyesore to strcpy(userdomain, username); my_strupr(userdomain); as well...? I find this sort of chaining of function calls tremendously hard to read. (... in a ntlm.c cleanup 5/4 patch :)) gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany g...@greenie.muc.de fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel