On Sat, Nov 04 2017, Gert Doering <g...@greenie.muc.de> wrote: > ACK, thanks. Reviewed by "staring at the code" (changes are only what it > says on the tin), compiling with clang and gcc (no format related warnings), > and running tests, of course :-)
Cool, thank you for your time. > I'm a bit undecided whether this should go to release/2.4 as well, as it > is "refactoring" and our general policy is "refactoring goes into master" > (but then it's straightforward enough). Leaving it in master for now, > but I can be convinced that we want this in 2.4... FWIW I'm fine with whatever approach you prefer. openvpn-2.5.0 will hopefully be released before 2038. :) Here's another small diff, I forgot one suseconds_t occurrence.
From cbe8237ff59129501e1e92c8fd6a3488d94c4c0f Mon Sep 17 00:00:00 2001
From: Jeremie Courreges-Anglas <j...@wxcvbn.org>
Date: Sun, 5 Nov 2017 10:03:26 +0100
Subject: [PATCH] Cast and print another suseconds_t as long
Missed in 31b5c0e
---
src/openvpn/forward.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c
index a91a8d9a..1b7455bb 100644
--- a/src/openvpn/forward.c
+++ b/src/openvpn/forward.c
@@ -649,7 +649,7 @@ check_timeout_random_component_dowork(struct context *c)
c->c2.timeout_random_component.tv_usec = (time_t) get_random() & 0x0003FFFF;
c->c2.timeout_random_component.tv_sec = 0;
- dmsg(D_INTERVAL, "RANDOM USEC=%d", (int) c->c2.timeout_random_component.tv_usec);
+ dmsg(D_INTERVAL, "RANDOM USEC=%ld", (long) c->c2.timeout_random_component.tv_usec);
}
static inline void
--
2.14.3
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
