On 03/06/18 12:11, Steffan Karger wrote:
> Can be suppressed by adding a "nowarn" flag to the compress options, for
> those that are really sure that compression is fine for their use case.
>
> Signed-off-by: Steffan Karger <stef...@karger.me>
> ---
> This patch is also meant to discuss how far we want to go in warning
> users about using compression. I think this approach is reasonable,
> but I'm not sure everyone agrees.
>
> doc/openvpn.8 | 11 +++++++++--
> src/openvpn/comp.c | 14 ++++++++++++++
> src/openvpn/comp.h | 1 +
> 3 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/doc/openvpn.8 b/doc/openvpn.8
> index 9e988b3..21a3c42 100644
> diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c
> index a945913..a34e64a 100644
> --- a/src/openvpn/comp.c
> +++ b/src/openvpn/comp.c
> @@ -40,6 +40,20 @@
> struct compress_context *
> comp_init(const struct compress_options *opt)
> {
> + switch (opt->alg)
> + {
> + case COMP_ALG_UNDEF:
> + case COMP_ALG_STUB:
> + case COMP_ALGV2_UNCOMPRESSED:
> + break;
> + default:
> + if (!(opt->flags & COMP_F_NOWARN))
> + {
> + msg(M_INFO, "WARNING: Compression enabled, might be insure. "Did you mean /insecure/? -- kind regards, David Sommerseth OpenVPN Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
