Hi, On Sun, Aug 19, 2018 at 10:07:03PM +0200, Gert Doering wrote: > --topology should have no effect in tap mode (tap is always "subnet"), > but due to the way options are checked, setting "topology subnet" caught > an improper branch on all non-linux and non-win32 platforms. > > Easily tested by adding "--topology subnet" to a "--dev tap" t_client > test. > > Tested, verified, and fixed on FreeBSD 10.4, NetBSD 7.0.1, OpenBSD 6.0, > and OpenSolaris 10. Compile-tested on MacOS X. > > Trac: #1085
Oh, because the comments omits that notice (it is in the ticket) - this
is 2.4 only. Master looks sufficiently different that this won't apply,
and Antonio and I have already conspired and decided that this needs to
be fixed for good in master - like:
- introduce a new enum "interface_style" or so, which can be
"TUN_MODE_P2P", "TUN_MODE_SUBNET" and "TAP_MODE" (or so)
- drop "tun", which tries to do the above in boolean form and fails
- in all platform code, have a switch/case statement instead of a
chained or nested if/else, making more explicit what the variants
are - or, if multiple if/else, at least have unambiguous conditions
(Before you ask: "net30" is not handled as subnet internally - except
on windows - but as point-to-point tun)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
