Acked-by: Gert Doering <[email protected]>
This is code I can even understand (to some extent) ;-) - overall it looks
good, but a few style warts sneaked in...
+finish_QueryServiceStatusEx:;
+
+ // Service is not started. Is it set to auto-start?
+ // MSDN describes the maximum buffer size for QueryServiceConfig() to be
8kB.
+ // This is small enough to fit on stack.
.. there shouldn't be a ";" after a label, and no C++ comments... but
I assume the uncrustify patch coming next will fix that...
Something else might not be obvious to the reader:
+ if (pQsc->dwStartType <= SERVICE_AUTO_START)
+ {
so what does "lesser than AUTO_START" mean? manual start? no start at
all? Comparing for "lesser or equal" with something enum-like might
warrant a comment /* BOOT_START = 0, SYSTEM_START = 1, AUTO_START = 2 */
or so... (yes, I can google this, but still).
Compile tested on Ubuntu 16.04 / mingw.
Your patch has been applied to the master branch.
commit 8148ee9d01de75d0302f224ef499eddfabc6fee2
Author: Simon Rozman
Date: Wed Dec 19 21:26:09 2018 +0100
Extend FindSystemInfo custom action to detect OpenVPNService state
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg18039.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
