On 13/06/2019 15:48, Arne Schwabe wrote: > From: Arne Schwabe <a...@openvpn.net> > > This is useful for features that can use enither a persistent > or an ephemeral key. > > Patch V2: Move the functionality of generating a random key into a > separate function that acts as wrapper for pem_read_key_file > Patch V4: Move wrapper functionality to caller and leave only generate > epehermal key functionality in the new function > --- > src/openvpn/crypto.c | 14 ++++++++++++++ > src/openvpn/crypto.h | 12 +++++++++++- > 2 files changed, 25 insertions(+), 1 deletion(-)
This looks good ... but one nit-pick, but can be fixed during commit: > diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h > index c5947483..72244997 100644 > --- a/src/openvpn/crypto.h > +++ b/src/openvpn/crypto.h > @@ -428,7 +428,17 @@ unsigned int crypto_max_overhead(void); [....]> +/** > + * Generate ephermal key material into the key structure or if ^^^^^ This comment don't need those two last words, but that can be fixed during commit time. Acked-By: David Sommerseth <dav...@openvpn.net> -- kind regards, David Sommerseth OpenVPN Inc _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel