Hi Arne,
On 12/08/2019 15:45, Arne Schwabe wrote:
> Clang/Android complained
>
> warning: address of array 'rgi6->iface' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (rgi6->iface)
>
> iface is a char[16]; So its pointer is always true.
>
> we do a CLEAR(rgi6) always before setting this struct and strcpy the
> name into iface. So using strlen instead of checking for the pointer
> should be the right fix.
Thanks for fixing this!
However you're missing the signed off line.
> ---
> src/openvpn/route.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvpn/route.c b/src/openvpn/route.c
> index 5f63fd34..a302746e 100644
> --- a/src/openvpn/route.c
> +++ b/src/openvpn/route.c
> @@ -3349,7 +3349,7 @@ get_default_gateway_ipv6(struct route_ipv6_gateway_info
> *rgi6,
> rgi6->flags |= RGI_ADDR_DEFINED;
> }
>
> - if (rgi6->iface)
> + if (strlen(rgi6->iface))
how about adding a "> 0"? I know it's basically the same here, but I
think that's the style we use everywhere.
Cheers,
> {
> rgi6->flags |= RGI_IFACE_DEFINED;
> }
>
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
