Hi, I've yet again rebased the last attempt of the struct argv overhaul patches [1] to the latest public git master [2].
This rebase just needed a few minor changes to account for changes with tls-crypt-v2 and sitnl patches now being included. I've also applied Arne's review comments [3]. To simplify the review, I've also pushed these changes to my gitlab account: https://gitlab.com/dazo/openvpn.git Look at the dev/struct-argv-overhaul-2020.02 [4] branch for the proper commits. This patch-set supersedes the "struct argv overhaul - Oct 2019 edition" patches [5] [1] <https://patchwork.openvpn.net/project/openvpn2/list/?series=386&state=%2A&archive=both> [2] git master commit 5822e52c6b0f86f9e4de946f9fb1374c6fad95f1 [3] Message-ID: <fef5a979-ccff-71c2-61c8-1bd8ead96...@rfc2549.org> <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17957.html> [4] <https://gitlab.com/dazo/openvpn/-/tree/dev/struct-argv-overhaul-2020.02> [5] <https://patchwork.openvpn.net/project/openvpn2/list/?series=553&state=%2A&archive=both> -- kind regards, David Sommerseth OpenVPN Inc --------------------------------------------------------------------------- David Sommerseth (1): Documented all the argv related code with minor refactoring Heiko Hund (3): re-implement argv_printf_*() argv: do fewer memory re-allocations Add gc_arena to struct argv to save allocations src/openvpn/argv.c | 541 +++++++++++++++++---------- src/openvpn/argv.h | 7 +- src/openvpn/console_systemd.c | 2 +- src/openvpn/init.c | 15 +- src/openvpn/lladdr.c | 2 +- src/openvpn/multi.c | 10 +- src/openvpn/networking_iproute2.c | 23 +- src/openvpn/options.c | 2 +- src/openvpn/plugin.c | 2 +- src/openvpn/route.c | 16 +- src/openvpn/socket.c | 4 +- src/openvpn/ssl_verify.c | 6 +- src/openvpn/tls_crypt.c | 2 +- src/openvpn/tun.c | 62 +-- tests/unit_tests/openvpn/test_argv.c | 118 +++++- 15 files changed, 518 insertions(+), 294 deletions(-) -- 2.17.1 _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
