Hi,
Tested with Windows server and Linux client, negotiation works.
A few nit-picks, which could be fixed with follow-up patch:
> + * @param gc gc arena that is ONLY used to allocate the returned string
This is not true, since it is also used inside tls_peer_ncp_list()
to generate temp string containing client pushed ciphers.
> +ncp_get_best_cipher(const char *server_list, const char *server_cipher,
> + const char *peer_info, const char *remote_cipher,
> + struct gc_arena *gc)
> +{
> + const char *peer_ncp_list = tls_peer_ncp_list(peer_info, gc);
That gc has lifetime of VPN tunnel and is used here to allocate
a temp string which is needed only in this function.
> - const char *config_authname;
This doesn't seem to be related to NCP negotiation.
Acked-by: Lev Stipakov <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
