Your patch has been applied to the master branch.
Taking the ACK from Lev on the v4 patch, verified that v5 has the same
code changes ("diff -uw v4.txt v5.txt") and that the difference is indeed
only in the test module.
Tested on FreeBSD 11.3 / openssl 1.0.2s which does not have chacha20-poly
and *does* have AES-GCM. The output is:
[ RUN ] test_check_ncp_ciphers_list
Unsupported cipher in --ncp-ciphers: CHACHA20-POLY1305
Unsupported cipher in --ncp-ciphers: vollbit
Unsupported cipher in --ncp-ciphers: vollbit
[ OK ] test_check_ncp_ciphers_list
.. which looks good to me.
Given David's comment about breakage on RHEL 7.7, I tried building
and testing on "CentOS 7.7.1908" with "OpenSSL 1.0.2k 19.el7", which
hopefully relates. It also passes nicely...
[==========] Running 4 test(s).
[ RUN ] test_check_ncp_ciphers_list
Unsupported cipher in --ncp-ciphers: CHACHA20-POLY1305
Unsupported cipher in --ncp-ciphers: vollbit
Unsupported cipher in --ncp-ciphers: vollbit
[ OK ] test_check_ncp_ciphers_list
So, I consider David's NAK to be sufficiently addressed :-)
commit 1828f9c199cc8cdf4e9d8d0bf072e726604f69dc
Author: Arne Schwabe
Date: Fri Feb 21 11:07:46 2020 +0100
Move NCP related function into a seperate file and add unit tests
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg19499.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
